linux-kernel - Re: [PATCH] MODSIGN: Add TAINT_NOKEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130117150202.GB32586@redhat.com>
Date:	Thu, 17 Jan 2013 10:02:02 -0500
From:	Dave Jones <davej@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Josh Boyer <jwboyer@...hat.com>,
	"Frank Ch. Eigler" <fche@...hat.com>, dhowells@...hat.com,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	mingo@...hat.com
Subject: Re: [PATCH] MODSIGN: Add TAINT_NOKEY_MODULE

On Thu, Jan 17, 2013 at 11:27:27AM +1030, Rusty Russell wrote:
 
 > taint: add explicit flag to show whether lock dep is still OK.
 > 
 > Fix up all callers as they were before, with make one change: an
 > unsigned module taints the kernel, but doesn't turn off lockdep.
 > 
 > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
 
This made my brain itch a little until I got to the bottom of the
patch and saw the new definition of add_taint.  Perhaps instead of
false/true, we have LOCKDEP_LIVES/LOCKDEP_DIES or similar defines
to make it clearer what's actually happening without having to
go read the function ?

 > + * If something bad has gone wrong, you'll want @lockdebug_ok = false, but for
 > + * some notewortht-but-not-corrupting cases, it can be set to true.
 > + */

'noteworthy'

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/