linux-kernel - Re: [PATCH] fix setup_efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <50F8297002000078000B6E64@nat28.tlf.novell.com>
Date:	Thu, 17 Jan 2013 15:40:16 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Matt Fleming" <matt@...sole-pimps.org>
Cc:	"Bjorn Helgaas" <bhelgaas@...gle.com>,
	"Matthew Garrett" <mjg59@...f.ucam.org>,
	"linux-efi" <linux-efi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix setup_efi_pci()

>>> On 17.01.13 at 13:29, Matt Fleming <matt@...sole-pimps.org> wrote:
> On Mon, 2013-01-14 at 08:59 +0000, Jan Beulich wrote:
>> This fixes three issues:
>> - missing parentheses around a flag test
>> - wrong memory type used for allocation intended to persist post-boot
>> - four similar build warnings on 32-bit (casts between different size
>>   pointers and integers)
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...e.com>
>> 
>> ---
>>  arch/x86/boot/compressed/eboot.c |   12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Jan, could you resubmit items 2 and 3 as separate patches please?

Sure, will do (probably only after rc4 though).

> Item 1 on your list has already been fixed in Linus' tree,

Yet I know I checked the tree right before sending...

Jan

> commit 886d751a2ea99a160f2d0a472231566d9cb0cf58
> Author: Sasha Levin <sasha.levin@...cle.com>
> Date:   Thu Dec 20 14:11:33 2012 -0500
> 
>     x86, efi: correct precedence of operators in setup_efi_pci
>     
>     With the current code, the condition in the if() doesn't make much sense 
> due
>     precedence of operators.
>     
>     Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
>     Link: 
> http://lkml.kernel.org/r/1356030701-16284-25-git-send-email-sasha.levi 
>     Cc: Matt Fleming <matt.fleming@...el.com>
>     Cc: Matthew Garrett <mjg@...hat.com>
>     Cc: Bjorn Helgaas <bhelgaas@...gle.com>
>     Cc: Seth Forshee <seth.forshee@...onical.com>
>     Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
> 
> -- 
> Matt Fleming, Intel Open Source Technology Center



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/