linux-kernel - Re: [PATCH] platform: Fix platform device resource linking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130117163159.GD1396@kroah.com>
Date:	Thu, 17 Jan 2013 08:31:59 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:	linux-kernel@...r.kernel.org, Matt Porter <mporter@...com>,
	Russ Dill <Russ.Dill@...com>,
	Koen Kooi <koen@...inion.thruhere.net>
Subject: Re: [PATCH] platform: Fix platform device resource linking

On Fri, Jan 04, 2013 at 12:43:46AM +0200, Pantelis Antoniou wrote:
> Hi Greg,
> 
> On Jan 4, 2013, at 12:40 AM, Greg Kroah-Hartman wrote:
> 
> > On Fri, Jan 04, 2013 at 12:31:10AM +0200, Pantelis Antoniou wrote:
> >> Platform device removal uncovered a number of problems with
> >> the way resources are handled in the core platform code.
> >> 
> >> Resources now form child/parent linkages and this requires
> >> proper linking of the resources. On top of that the OF core
> >> directly creates it's own platform devices. Simplify things
> >> by providing helper functions that manage the linking properly.
> >> 
> >> Two functions are provided:
> >> 
> >> platform_device_link_resources(), which links all the
> >> linkable resources (if not already linked).
> >> 
> >> and platform_device_unlink_resources(), which unlinks all the
> >> resources.
> > 
> > Who would call these functions, and why?
> > 
> > And why have we never seen problems with removing platform devices
> > previously?
> > 
> 
> Have you tried removing devices that were created via DT and 
> not using platform data?

Don't you think that answering two questions with another question as
something that isn't very helpful?  :)

Dropped from my queue, please resend when you can provide the needed
information.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/