linux-kernel - Re: [PATCH] rtc: hid-sensor-time: Add missing spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACnwZYfV=czMR=FLwQseubK-G8GnuiVW_wsnFKTnw=rHrZ8dgg@mail.gmail.com>
Date:	Wed, 16 Jan 2013 23:58:38 -0200
From:	Thiago Farina <tfransosi@...il.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Alexander Holler <holler@...oftware.de>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: hid-sensor-time: Add missing spin_lock_init

On Wed, Jan 16, 2013 at 11:49 PM, Axel Lin <axel.lin@...ics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/rtc/rtc-hid-sensor-time.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-hid-sensor-time.c b/drivers/rtc/rtc-hid-sensor-time.c
> index 0438c9e..31c5728 100644
> --- a/drivers/rtc/rtc-hid-sensor-time.c
> +++ b/drivers/rtc/rtc-hid-sensor-time.c
> @@ -225,6 +225,7 @@ static int hid_time_probe(struct platform_device *pdev)
>
>         platform_set_drvdata(pdev, time_state);
>
> +       spin_lock_init(&time_state->lock_last_time);
Can you explain in the commit message why it is missing?

For people not familiar with this code that isn't obvious.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/