linux-kernel - Re: [PATCH] 3c574_cs: fix operator precedence between << and &

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130117.150502.1981147330754808185.davem@davemloft.net>
Date:	Thu, 17 Jan 2013 15:05:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nickolai@...il.mit.edu
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 3c574_cs: fix operator precedence between << and &

From: Nickolai Zeldovich <nickolai@...il.mit.edu>
Date: Thu, 17 Jan 2013 12:18:29 -0500

> The code to print the FIFO size in tc574_config computes it as:
> 
>   8 << config & Ram_size
> 
> which evaluates the '<<' first, but the actual intent is to evaluate the
> '&' first.  Add parentheses to enforce desired evaluation order.
> 
> Signed-off-by: Nickolai Zeldovich <nickolai@...il.mit.edu>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/