linux-kernel - Re: [PATCH v2] HID: i2c-hid: add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=GBYbCxrOKk2S1n9K2e68Rbxvt4CuoV40NJiE9LDNR=Zw@mail.gmail.com>
Date:	Thu, 17 Jan 2013 16:52:55 -0500
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	linux-input@...r.kernel.org, Jean Delvare <khali@...ux-fr.org>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: add ACPI support

On Wed, Jan 9, 2013 at 9:52 AM, Jiri Kosina <jkosina@...e.cz> wrote:
> On Wed, 9 Jan 2013, Benjamin Tissoires wrote:
>
>> <mika.westerberg@...ux.intel.com> wrote:
>> > The HID over I2C protocol specification states that when the device is
>> > enumerated from ACPI the HID descriptor address can be obtained by
>> > executing "_DSM" for the device with function 1. Enable this.
>> >
>> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
>>
>> I'm eager to test it (hopefully next week).
>>
>> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
>
> Perfect. I will wait for your Tested-by: as well before applying to public
> git tree.

Hi Jiri,

well, we tried yesterday to make all those things working, but the
Haswell platform I was able to have access was not very cooperative.
So I wasn't able to test the whole autodetection mechanism through
ACPI (I even not managed to communicate with the various HID over i2c
devices that were available to test).

However, Mika managed to test this ACPI stuff, and he is able to
retrieve the HID descriptor address. Given that, I think it's safe to
include it right now. There will still be the last point with the
gpios, but it will come when someone get access to a device presenting
this feature.

Cheers,
Benjamin

>
> Thanks to both of you,
>
> --
> Jiri Kosina
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/