linux-kernel - Re: LIO - the broken iSCSI target implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1358463656.18551.158.camel@haakon2.linux-iscsi.org>
Date:	Thu, 17 Jan 2013 15:00:56 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Andy Grover <agrover@...hat.com>
Cc:	Andreas Steinmetz <ast@...dv.de>, linux-kernel@...r.kernel.org,
	hch@...radead.org, torvalds@...ux-foundation.org,
	target-devel <target-devel@...r.kernel.org>,
	Ritesh Raj Sarraf <rrs@...ian.org>
Subject: Re: LIO - the broken iSCSI target implementation

On Thu, 2013-01-17 at 14:31 -0800, Andy Grover wrote:
> On 01/17/2013 12:56 PM, Nicholas A. Bellinger wrote:
> > On Thu, 2013-01-17 at 02:19 +0100, Andreas Steinmetz wrote:
> >> This is not a technical point of view. This is a more or less political
> >> and user point of view. And for any replies, I'm not subscribed (haven't
> >> been now for years).
> >>
> >> As a user, I was in need for an iSCSI target. Actually, I needed to
> >> export a SAS tape device (Ultrium 5) - which is one of the devices still
> >> sufficiently expensive to go the iSCSI target way) - well, not any disks
> >> (cheap enough, NFS available) or CD/DVD writers (I'd call these penny
> >> targets nowadays).
> >>
> >> Thus, lio (http://www.linux-iscsi.org/) seemed to be the politically and
> >> technically favoured solution. Except: it simply doesn't work, userspace
> >> utilities are seemingly not maintained,
> > 
> > I'm not sure what you mean.  There are targetcli+rtslib packages are
> > available for virtually every distribution
> > 
> > http://www.linux-iscsi.org/wiki/Targetcli#Linux_distributions
> 
> [CCing rrs@...ian.org]
> 
> No... actually upstream targetcli/rtslib are not very well maintained.
> Around 5 patches each in the last year.
> 
> Meanwhile, I have been actively maintaining branches at
> github.com/agrover/targetcli-fb and github.com/agrover/rtslib-fb. We
> have a man page and screencasts even. Feel free to file bugs against
> them and I'll respond.
> 
> But I'm only packaging for Fedora/RHEL, so random people on Debian etc.
> get a bad experience. I'd like to see upstream accept my AGPLv3-licensed
> patches, or have Debian package the -fb versions, either instead or in
> addition to the upstream versions.
> 

So would I, but we've (RTS) been too busy having to work on other stuff
to pay the extensive legal bills from the fallout that your previous
public accusations have wrought. 

Even though your over it, it doesn't mean other opportunists did not try
to take advantage of the situation once you got tired and moved onto
other target userspace related things.

> (I'd kinda been waiting to bring it up until upstream had no commits in
> a year, but since you mentioned it...)

In any event, I don't really have a problem with merging the two if your
finally over the fact the userspace code is AGPL licensed. 

But please do this in a separate thread than piling on here.  Of course,
your more than welcome to fix rtslib for pSCSI, which is broken on
recent v3.x kernels.

(Hint: it's because /sys/class/scsi_device/H:C:T:L/device/block/$BLOCK_DEV
 no longer exists in upstream sysfs, which is what we use to match the passed
 /dev/$SCSI_DEV to H:C:T:L, and nothing related to TCM ABI changes)

Thanks,

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/