linux-kernel - Re: [PATCH] drivers: xhci: fix incorrect bit test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130117003837.GA11383@xanatos>
Date:	Wed, 16 Jan 2013 16:38:37 -0800
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Nickolai Zeldovich <nickolai@...il.mit.edu>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: xhci: fix incorrect bit test

Hi Nickolai,

Thanks for catching this.  Don't worry about sending a new patch with
the short description for the commit, I'll fix that when I send it off.

Sarah Sharp

On Mon, Jan 07, 2013 at 10:39:31PM -0500, Nickolai Zeldovich wrote:
> Fix incorrect bit test that originally showed up in
> 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'.
> 
> Signed-off-by: Nickolai Zeldovich <nickolai@...il.mit.edu>
> ---
>  drivers/usb/host/xhci-ring.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index cbb44b7..06921b6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1698,7 +1698,7 @@ static void handle_port_status(struct xhci_hcd *xhci,
>  				faked_port_index + 1);
>  		if (slot_id && xhci->devs[slot_id])
>  			xhci_ring_device(xhci, slot_id);
> -		if (bus_state->port_remote_wakeup && (1 << faked_port_index)) {
> +		if (bus_state->port_remote_wakeup & (1 << faked_port_index)) {
>  			bus_state->port_remote_wakeup &=
>  				~(1 << faked_port_index);
>  			xhci_test_and_clear_bit(xhci, port_array,
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/