linux-kernel - Re: [PATCH 1/2] regulator: wm8994: Convert wm8994_ldo2_ops to use regulator_list_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130118061357.GA4960@opensource.wolfsonmicro.com>
Date:	Fri, 18 Jan 2013 15:13:59 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: wm8994: Convert wm8994_ldo2_ops to use
 regulator_list_voltage_linear

On Fri, Jan 18, 2013 at 11:58:33AM +0800, Axel Lin wrote:

> +	/* LDO2, id starts from 0 */
> +	if (id == 1) {
> +		switch (wm8994->type) {
> +		case WM8994:
> +			wm8994_ldo_desc[id].min_uV = 900000;
> +			wm8994_ldo_desc[id].uV_step = 100000;
> +			break;

This isn't going to work in the (admittedly unlikely) case where we have
two different devices using this driver in the system.  We shouldn't be
modifying static data like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/