linux-kernel - Re: [alsa-devel] [PATCH] ALSA: ASoC: McASP: Fix data rotation for playback. Enables 24bit audio playback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3861763.aeE9tah8r0@ganymedes>
Date:	Fri, 18 Jan 2013 09:43:40 +0100
From:	Michal Bachraty <michal.bachraty@...eamunlimited.com>
To:	"Hebbar, Gururaja" <gururaja.hebbar@...com>
Cc:	"tiwai@...e.de" <tiwai@...e.de>, "perex@...ex.cz" <perex@...ex.cz>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"Girdwood, Liam" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ALSA: ASoC: McASP: Fix data rotation for playback. Enables 24bit audio playback

On Friday, January 18, 2013 08:22:53 Hebbar, Gururaja wrote:
> On Tue, Jan 15, 2013 at 20:11:00, Michal Bachraty wrote:
> > Signed-off-by: Michal Bachraty <michal.bachraty@...eamunlimited.com>
> 
> Even simple patches need a simple changelog.
> Add a brief description about what & why it is done?
> 

Hi Gurujaja,

> > -	u32 rotate = (32 - word_length) / 4;
This implementation is wrong, but it works only for 16, or 32 bit audio data.
(rotation for 16 or 32 bit is same as in code I present) Mcasp rotated data in 
4 bits (max value 0x7)and then masks them . That data are sended to i2s bus. 
For 24 bit or 20 bit or other data formats, this code rotates data badly and 
you hear somethink like noise.  You need to use
> > +	u32 rotate = (word_length / 4) & 0x7;
to proper data rotation. 

Regards,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/