lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jan 2013 16:46:16 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com> Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org, alan@...rguk.ukuu.org.uk, Alexander Beregalov <a.beregalov@...il.com>, Theodore Tso <tytso@....edu>, Zheng Liu <wenqing.lz@...bao.com> Subject: Re: [ 36/71] ext4: lock i_mutex when truncating orphan inodes On Thu, Jan 17, 2013 at 06:07:11PM -0200, Herton Ronaldo Krzesinski wrote: > On Tue, Jan 15, 2013 at 02:54:33PM -0800, Greg Kroah-Hartman wrote: > > 3.0-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Theodore Ts'o <tytso@....edu> > > > > commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream. > > > > Commit c278531d39 added a warning when ext4_flush_unwritten_io() is > > called without i_mutex being taken. It had previously not been taken > > during orphan cleanup since races weren't possible at that point in > > the mount process, but as a result of this c278531d39, we will now see > > a kernel WARN_ON in this case. Take the i_mutex in > > ext4_orphan_cleanup() to suppress this warning. > > > > Reported-by: Alexander Beregalov <a.beregalov@...il.com> > > Signed-off-by: "Theodore Ts'o" <tytso@....edu> > > Reviewed-by: Zheng Liu <wenqing.lz@...bao.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > > By the description and looking at commit c278531d39, this change isn't > needed for 3.0 or 3.4 kernels (anything <= 3.6), they don't contain > commit c278531d39. Ah, good catch. Should this be reverted from 3.0 and 3.4? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists