linux-kernel - Re: [PATCH] tty: serial/crisv10.c: remove unnecessary null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130118133821.GQ23529@axis.com>
Date:	Fri, 18 Jan 2013 14:38:22 +0100
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Cong Ding <dinggnu@...il.com>
Cc:	Mikael Starvik <starvik@...s.com>, Alan Cox <alan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: serial/crisv10.c: remove unnecessary null pointer
 check

On Wed, Jan 16, 2013 at 11:30:44PM +0100, Cong Ding wrote:
> The pointer tty is dereferened in line 3135, so it is not necessary to check
> null again in line 3140.

I don't know if we actually need to check the parameter tty from being null,
but when checking the rest of the file, most other functions don't check it.

In any case, gcc is quite likely to remove that check due to the
earlier dereference, so removing it is probably acceptable.

> Signed-off-by: Cong Ding <dinggnu@...il.com>

Thanks, I'll take it in the CRIS tree.

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/