linux-kernel - Re: [PATCH v3 2/2] perf stat: add interval printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130118183030.GE4051@tassilo.jf.intel.com>
Date:	Fri, 18 Jan 2013 10:30:30 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	acme@...hat.com, jolsa@...hat.com, namhyung.kim@....com
Subject: Re: [PATCH v3 2/2] perf stat: add interval printing

>  	if (forks) {
>  		close(go_pipe[1]);
> +		if (interval) {
> +			while (!waitpid(child_pid, &status, WNOHANG)) {
> +				ret = nanosleep(&ts, NULL);
> +				if (ret == 0 && interval)
> +					print_interval();

It would be good to make sure that if someone Ctrl-Cs
you still print the latest interval(even if shorter)

The rest looks good to me.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/