linux-kernel - Re: [PATCH] platform: Fix platform device resource linking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <76227CCE-90D9-425B-8187-E1B896E0664B@antoniou-consulting.com>
Date:	Fri, 18 Jan 2013 21:52:20 +0200
From:	Pantelis Antoniou <panto@...oniou-consulting.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, Matt Porter <mporter@...com>,
	Russ Dill <Russ.Dill@...com>,
	Koen Kooi <koen@...inion.thruhere.net>
Subject: Re: [PATCH] platform: Fix platform device resource linking

Hi Greg,

On Jan 18, 2013, at 9:47 PM, Greg Kroah-Hartman wrote:

> On Fri, Jan 18, 2013 at 11:05:14AM +0200, Pantelis Antoniou wrote:
>> It might make sense for the of_device_* functions that are duplicating 
>> platform_device_* functions to be removed, and their functionality to 
>> be subsumed by platform_device_*, possibly by calling some helper functions
>> in drivers/of/ when of_node is not NULL. The of_device_* functions can be 
>> replaced by a direct call to platform_device_* via a define (until all of
>> the callers get converted).
> 
> That sounds reasonable.
> 
>> The problem with doing anything like this would be that a whole bunch of
>> devices/arches depend on DT, and if anything breaks there will be a lot of
>> angry people with pitchforks after the culprit.
> 
> That's nothing new, we are totally used to that happening :)
> 

I'm fearful of the angry mob with torches and pitchforks after me, if something
gets broken :)

>> So without the full force of a core maintainer behind such a move, people
>> are reluctant to do so.   
> 
> Send patches if you want to do this, no need for the maintainer to do it
> (hint, I will not as I don't even have a system that this type of code
> runs on.)
> 

OK, maybe next week, when I think of this a little bit more.

> thanks,
> 
> greg k-h

Regards

-- Pantelis--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/