linux-kernel - Re: [PATCH 1/3] wlan-ng/prism2mgmt.c: added parenthesis to macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Jan 2013 13:02:11 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sebastian Ehrenfels <qi50dube@....cs.fau.de>
Cc:	linux-kernel@...informatik.uni-erlangen.de,
	devel@...verdev.osuosl.org,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-kernel@...r.kernel.org,
	Sebastian Wankerl <sisewank@....cs.fau.de>
Subject: Re: [PATCH 1/3] wlan-ng/prism2mgmt.c: added parenthesis to macro

On Fri, Jan 18, 2013 at 12:07:30AM +0100, Sebastian Ehrenfels wrote:
> From: Sebastian Wankerl <sisewank@....cs.fau.de>
> 
> Signed-off-by: Sebastian Wankerl <sisewank@....cs.fau.de> 
> Signed-off-by: Sebastian Ehrenfels <qi50dube@....cs.fau.de> 

Why did you do this?  What does this fix?  Please always say that in the
change log entry part of the patch, empty ones aren't ok.

And why do you have trailing spaces on your signed-off-by: lines?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/