linux-kernel - Re: [PATCH 2/2] decompressors: make the default XZ_BCJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130118230641.42bbb191@tukaani.org>
Date:	Fri, 18 Jan 2013 23:06:41 +0200
From:	Lasse Collin <lasse.collin@...aani.org>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] decompressors: make the default XZ_BCJ_* config
 match the selected architecture

On 2013-01-16 Florian Fainelli wrote:
> On 01/15/2013 07:11 PM, Lasse Collin wrote:
> > On 2013-01-15 Florian Fainelli wrote:
> >>   config XZ_DEC_X86
> >>   	bool "x86 BCJ filter decoder" if EXPERT
> >> -	default y
> >> +	default y if X86
> >>   	select XZ_DEC_BCJ
> > [...]
> >
> > I think the "if EXPERT" strings should be dropped when all BCJ
> > filters aren't enabled by default. One should be able to enable all
> > filters without enabling EXPERT.
> Ok, this would probably be a third patch, since my two patches
> basically just modify what was already there, but I agree with you,
> even though EXPERT is enabled by default on most architectures and
> defconfigs. --

At least in x86_64_defconfig EXPERT isn't enabled. I'm fine with your
patches once also the "if EXPERT" strings are removed.

Acked-by: Lasse Collin <lasse.collin@...aani.org>

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/