linux-kernel - Re: [PATCH] ACPI / scan: Drop acpi_bus_add() and use acpi_bus_scan() instead (was: Re: [PATCH] ACPI / scan: Fold acpi_bus_scan() into acpi_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE9FiQW6+W99nqfsYokU0eVe57zLbiKYojVYNSs7Yvke8PnpRw@mail.gmail.com>
Date:	Fri, 18 Jan 2013 14:59:06 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Moore, Robert" <robert.moore@...el.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] ACPI / scan: Drop acpi_bus_add() and use acpi_bus_scan()
 instead (was: Re: [PATCH] ACPI / scan: Fold acpi_bus_scan() into acpi_bus_add())

On Fri, Jan 18, 2013 at 1:55 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Subject: ACPI / scan: Drop acpi_bus_add() and use acpi_bus_scan() instead
>
> The only difference between acpi_bus_scan() and acpi_bus_add() is the
> invocation of acpi_update_all_gpes() in the latter which in fact is
> unnecessary, because acpi_update_all_gpes() has already been called
> by acpi_scan_init() and the way it is implemented guarantees the next
> invocations of it to do nothing.
>
> For this reason, drop acpi_bus_add() and make all its callers use
> acpi_bus_scan() directly instead of it.  Additionally, rearrange the
> code in acpi_scan_init() slightly to improve the visibility of the
> acpi_update_all_gpes() call in there.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/acpi/acpi_memhotplug.c     |    2 -
>  drivers/acpi/container.c           |    2 -
>  drivers/acpi/dock.c                |    2 -
>  drivers/acpi/processor_driver.c    |    2 -
>  drivers/acpi/scan.c                |   54 +++++++++++++++----------------------
>  drivers/pci/hotplug/acpiphp_glue.c |    4 +-
>  drivers/pci/hotplug/sgi_hotplug.c  |    4 +-
>  include/acpi/acpi_bus.h            |    2 -
>  8 files changed, 31 insertions(+), 41 deletions(-)

Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/