linux-kernel - Re: linux-next: Tree for Jan 18 [MODSIGN: KEYS:]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+icZUUjVdO9CBirU7j3kJbGGa6mRw2P46piZUpopqvPGzCU_A@mail.gmail.com>
Date:	Sat, 19 Jan 2013 00:27:27 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: linux-next: Tree for Jan 18 [MODSIGN: KEYS:]

On Sat, Jan 19, 2013 at 12:04 AM, Sedat Dilek <sedat.dilek@...il.com> wrote:
> On Fri, Jan 18, 2013 at 11:54 PM, David Howells <dhowells@...hat.com> wrote:
>> Sedat Dilek <sedat.dilek@...il.com> wrote:
>>
>>> Culprit seems to be...
>>>
>>> commit d6941c0c6bd42c725e45240a86c4add92e9bfb3e
>>> "KEYS: Separate the kernel signature checking keyring from module signing"
>>
>> Try updating.  I pushed a new version out today.  This is now at commit ID
>> c82af351e270e0d95059d09a1975b61494fbbcd7.
>>
>
> Thanks for the information!
>
> OK, I see... s/select/depends on...
>
>  +config SYSTEM_TRUSTED_KEYRING
>  +      bool "Provide system-wide ring of trusted keys"
> -+      select KEYS
> ++      depends on KEYS
>
> That should fix it :-).
> I set SYSTEM_TRUSTED_KEYRING=y in kernel-config.
>
> BAD: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=patch;h=d6941c0c6bd42c725e45240a86c4add92e9bfb3e
>
> GOOD: http://git.kernel.org/?p=linux/kernel/git/dhowells/linux-modsign.git;a=patch;h=c82af351e270e0d95059d09a1975b61494fbbcd7
>

I tried to revert the bad commit and replace it with the good one, but
this seems to be more work.
So, I fixed it up like in the attached patch.

- Sedat -

> - Sedat -
>
>> David

Download attachment "0001-KEYS-Fix-build-error-when-SYSTEM_TRUSTED_KEYRING-n.patch" of type "application/octet-stream" (1321 bytes)