linux-kernel - Re: [ 36/71] ext4: lock i_mutex when truncating orphan inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130118035650.GA13785@thunk.org>
Date:	Thu, 17 Jan 2013 22:56:50 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	Alexander Beregalov <a.beregalov@...il.com>,
	Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [ 36/71] ext4: lock i_mutex when truncating orphan inodes

On Fri, Jan 18, 2013 at 01:47:48AM -0200, Herton Ronaldo Krzesinski wrote:
> > > By the description and looking at commit c278531d39, this change isn't
> > > needed for 3.0 or 3.4 kernels (anything <= 3.6), they don't contain
> > > commit c278531d39.
> > 
> > Ah, good catch.  Should this be reverted from 3.0 and 3.4?
> 
> I judge it as unecessary from what I saw so far, can ext4 developers
> and/or people in Cc confirm? It should be harmless, only consequence is
> an uneeded lock being taken now in 3.0/3.4

It's not worth it to revert it.  The lock is being taken in a
completely non-fastpath, as well as guaranteed-to-be non-contended
code path.

We're not requiring that the lock be taken in 3.0 and 3.4, but
arguably it's still a good idea to take it from a consistency point of
view.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/