linux-kernel - Re: [PATCH v2 0/3] x86: enable common clk and add support for Lynxpoint clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2132297.E3RA4GlFZ9@vostro.rjw.lan>
Date:	Sat, 19 Jan 2013 01:17:36 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Len Brown <lenb@...nel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 0/3] x86: enable common clk and add support for Lynxpoint clocks

On Friday, January 18, 2013 03:45:58 PM Mika Westerberg wrote:
> This is second iteration of the series. First revision is available here:
> 
> 	https://lkml.org/lkml/2013/1/14/213
> 
> Idea is to let the LPSS peripheral drivers to use common clk framework to
> get clock rate or enable/disable the functional clock. The discussion
> started in this thread:
> 
> 	http://thread.gmane.org/gmane.linux.kernel/1417691
> 
> In summary, there is no point in adding a special case code to the drivers
> in order to pass them a fixed clock rate, but instead x86 should just
> enable common clk subsystem and take advantage of it.
> 
> We try to address that in this series. Instead of enabling the common clk
> framework by default we place it under CONFIG_X86_INTEL_LPSS config option.
> This option then selects what is necessary to support the LPSS peripheral
> drivers.
> 
> We then create the Lynxpoint clock tree and populate it accordingly.
> 
> Changes to previous version:
> 	- add config option CONFIG_X86_INTEL_LPSS
> 	- pass flags to acpi_create_platform_device() instead of calling
> 	  function in drivers/acpi/scan.c
> 	- create the clock platform devices in drivers/acpi/acpi_platform.c
> 
> Please review.
> 
> Mika Westerberg (3):
>   x86: add support for Intel Low Power Subsystem
>   clk: x86: add support for Lynxpoint LPSS clocks
>   ACPI / platform: create LPSS clocks if Lynxpoint devices are found
>     during scan
> 
>  arch/x86/Kconfig             |   10 +++++
>  drivers/acpi/acpi_platform.c |   25 ++++++++++-
>  drivers/acpi/internal.h      |    6 ++-
>  drivers/acpi/scan.c          |   22 +++++-----
>  drivers/clk/Makefile         |    1 +
>  drivers/clk/x86/Makefile     |    2 +
>  drivers/clk/x86/clk-lpss.c   |   99 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/clk/x86/clk-lpss.h   |   36 +++++++++++++++
>  drivers/clk/x86/clk-lpt.c    |   86 ++++++++++++++++++++++++++++++++++++
>  9 files changed, 275 insertions(+), 12 deletions(-)
>  create mode 100644 drivers/clk/x86/Makefile
>  create mode 100644 drivers/clk/x86/clk-lpss.c
>  create mode 100644 drivers/clk/x86/clk-lpss.h
>  create mode 100644 drivers/clk/x86/clk-lpt.c

This version looks OK to me, so if there are no objections, I'm going to
apply it.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/