linux-kernel - Re: Issues with "x86, um: switch to generic fork/vfork/clone" commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyRMC43_H1hL5goAQxX4EdTuXOu5A9CoBk9fpGoJT_nig@mail.gmail.com>
Date:	Sun, 20 Jan 2013 12:53:20 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Issues with "x86, um: switch to generic fork/vfork/clone" commit

On Sat, Jan 19, 2013 at 7:12 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> OK...  I think I understand what's going on.  We need asmlinkage_protect
> in sys_clone() ;-/  For what it's worth, I really wonder if we ought to
> treat that as syscall wrappers - i.e. have SYSCALL_DEFINEx on i386 add
> a wrapper that would do asmlinkage_protect itself.  IMO it's the same kind
> of thing as argument normalization handled by syscall wrappers - we make
> sure that C function plays well with what asm glue is doing and expecting.

Actually, I think we should do it *unconditionally* in the syscall wrappers.

It's up to the architecture code to make asmlinkage_protect() be a
no-op or not, depending on how it does things. Right now I think only
x86 actually defines it, although I suspect there might be others that
should (anybody who passes arguments on the stack and also uses the
stack for save-area).

But in the meantime, I guess I should just take the do_fork() one. Can
I get a sign-off and a changelog?

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/