linux-kernel - Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130120092839.GC16066@arwen.pp.htv.fi>
Date:	Sun, 20 Jan 2013 11:28:39 +0200
From:	Felipe Balbi <balbi@...com>
To:	Greg KH <greg@...ah.com>
CC:	fangxiaozhi 00110321 <fangxiaozhi@...wei.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<zihan@...wei.com>, <Lin.Lei@...wei.com>, <neil.yi@...wei.com>,
	<wangyuhua@...wei.com>, <huqiao36@...wei.com>, <balbi@...com>,
	<mdharm-usb@...-eyed-alien.net>, <sebastian@...akpoint.cc>
Subject: Re: USB: storage: optimize the matching rules and support new switch
 command for Huawei USB storage devices

Hi,

On Fri, Jan 18, 2013 at 03:43:59PM -0800, Greg KH wrote:
> On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote:
> > 
> > From: fangxiaozhi <huananhu@...wei.com>
> > 
> > 1. Optimize the matching rules with new macro for Huawei USB storage
> >    devices, to avoid to load USB storage driver for the modem interface
> >    with Huawei devices.
> > 2. Add to support new switch command for new Huawei USB dongles.
> > 
> > Signed-off-by: fangxiaozhi <huananhu@...wei.com>
> 
> This patch breaks the build, did you test it out?
> 
> I get the following errors:
> 
> drivers/usb/storage/unusual_devs.h:1530:1: error: implicit declaration of function ‘UNUSUAL_VENDOR_INTF’ [-Werror=implicit-function-declaration]
> drivers/usb/storage/unusual_devs.h:1534:3: warning: missing braces around initializer [-Wmissing-braces]
> drivers/usb/storage/unusual_devs.h:1534:3: warning: (near initialization for ‘us_unusual_dev_list[186]’) [-Wmissing-braces]
> drivers/usb/storage/unusual_devs.h:1534:3: error: initializer element is not constant
> drivers/usb/storage/unusual_devs.h:1534:3: error: (near initialization for ‘us_unusual_dev_list[186].vendorName’)
> drivers/usb/storage/unusual_devs.h:1537:1: warning: braces around scalar initializer [enabled by default]
> 
> And it goes on and on...
> 
> Care to fix this up and resend it?

Before resending make sure to scripts/checkpatch.pl and compile with
make C=1 for your ARM platform and x86 with allyesconfig, allnoconfig
and allmodconfig. In summary, follow Documentation/SubmitChecklist.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)