linux-kernel - Re: [PATCH] serial: lpc32xx: Fix fallout from tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Jan 2013 11:19:25 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Thierry Reding <thierry.reding@...onic-design.de>
CC:	Alan Cox <alan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion

On 01/18/2013 08:25 AM, Thierry Reding wrote:
> A duplicate definition of the port variable was introduced in the
> interrupt handler, which causes the build to break. The fix is to
> rename the variable to tport, which is already properly used in
> subsequent code.
> 
> Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
> ---
>  drivers/tty/serial/lpc32xx_hs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c
> index c01b58f..dffea6b 100644
> --- a/drivers/tty/serial/lpc32xx_hs.c
> +++ b/drivers/tty/serial/lpc32xx_hs.c
> @@ -322,7 +322,7 @@ exit_tx:
>  static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id)
>  {
>  	struct uart_port *port = dev_id;
> -	struct tty_port *port = &port->state->port;
> +	struct tty_port *tport = &port->state->port;

Oh, yeah, these arch-dependent drivers... This one is arm, tty-build
script has been updated here. Thanks for spotting and fixing.

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/