linux-kernel - Re: [PATCH] fat: eliminate iterations in fat_search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd-bjbKfyB_S3nEGA5s9HfZ-MzJurk6WtDFoHkfDhyfQOw@mail.gmail.com>
Date:	Mon, 21 Jan 2013 15:40:30 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ravishankar N <ravi.n1@...sung.com>
Subject: Re: [PATCH] fat: eliminate iterations in fat_search_long in case of EOD

2013/1/21, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>:
> Namjae Jeon <linkinjeon@...il.com> writes:
>
>> 2013/1/20, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>:
>>> Namjae Jeon <linkinjeon@...il.com> writes:
>>>
>>>> From: Namjae Jeon <namjae.jeon@...sung.com>
>>>>
>>>> When searching a directory for names, we can stop checking for further
>>>> entries if we detect End of Directory, i.e. if (de->name[0] ==
>>>> 0x00).The
>>>> current code traverses the cluster chain of a directory until a hit is
>>>> found or till the last cluster for that directory, ignoring the EOD
>>>> mark.
>>>> Fix this.
>>>
>>> f_pos still works fine after this change?
>> Hi OGAWA.
>> I can not find f_pos usage in fat_search_long function.
>> Maybe, Have you seen other function such as __fat_readdir ?
>> Let me know your opinion.
>
> Ah, I see. Only ->lookup. So, this makes behavior more strange.
> I.e. readdir() returns beyond 0, but lookup() can't find it?
Yes, Good point. I will check other places included readdir.
Thanks for review!
>
> Thanks.
> --
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/