linux-kernel - Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130121080506.GA8777@arwen.pp.htv.fi>
Date:	Mon, 21 Jan 2013 10:05:06 +0200
From:	Felipe Balbi <balbi@...com>
To:	Pali Rohár <pali.rohar@...il.com>
CC:	<balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

Hi,

On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote:
> On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> > On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > 
> > NAK for two reasons:
> > 
> > a) the original Nokia kernel used a separate g_file_storage
> > gadget to use Mass Storage mode, use that
> > 
> > b) there is no commit log
> 
> Reason why add mass storage mode to g_nokia is to avoid switching 
> between g_{file,mass}_storage and g_nokia and to have one gadget 
> driver for Nokia N900. It is better to have usb network and mass 
> storage mode in one driver (and not to unload & load another).
> 
> I tested this patch with 3.8-rc3 kernel on Nokia N900 and usb 
> network with mass storage mode working without problems.

Doesn't matter, in this case this is something which nokia wrote to
carry on their Maemo/MeeGo devices so unless someone from Nokia says
this is how they want to use nokia.c from now on, I can't simply risk
breaking all other users for your own convenience.

On top of all that, we're working to remove all gadget drivers from
kernel and keep only function drivers.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)