linux-kernel - Re: IPsec AH use of ahash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <861997288.94032.1358728848956.JavaMail.root@elliptictech.com>
Date:	Sun, 20 Jan 2013 19:40:49 -0500 (EST)
From:	Tom St Denis <tstdenis@...iptictech.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	David Dillow <dave@...dillows.org>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: IPsec AH use of ahash

----- Original Message -----
> From: "Borislav Petkov" <bp@...en8.de>
> To: "Steven Rostedt" <rostedt@...dmis.org>
> Cc: "Tom St Denis" <tstdenis@...iptictech.com>, "David Dillow" <dave@...dillows.org>, linux-kernel@...r.kernel.org,
> netdev@...r.kernel.org
> Sent: Sunday, 20 January, 2013 7:34:41 PM
> Subject: Re: IPsec AH use of ahash
> 
> On Sun, Jan 20, 2013 at 05:54:07PM -0500, Steven Rostedt wrote:
> > My God, you sound like a 2 year old.
> > 
> > Suck it up, and do the fixes. It's not the time you are worried
> > about,
> > as you most definitely spent more time bitching to everyone than it
> > would have taken you to clean up your work.
> 
> It's like you're reading my mind... :-)

The problem is for me to add the ()'s is a no brainer.

For me to re-write complete statements for coding style reasons means I have to actually go out and test it again.  In a proper IPsec lab that can take a couple of hours to make sure it's been run through its paces.  That's [among other things] the problem I have.  Re-writing perfectly good code because it doesn't meet coding "standards" that nobody else seems to match.

If you guys can't appreciate that I should just bow out of the discussion.  I didn't come here looking for a fight I came here to seek reason.

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/