linux-kernel - Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130121082643.GF8777@arwen.pp.htv.fi>
Date:	Mon, 21 Jan 2013 10:26:43 +0200
From:	Felipe Balbi <balbi@...com>
To:	Vivek Gautam <gautamvivek1987@...il.com>
CC:	<balbi@...com>, <linux-usb@...r.kernel.org>,
	<kgene.kim@...sung.com>, <p.paneri@...sung.com>,
	<gregkh@...uxfoundation.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>,
	<sylvester.nawrocki@...il.com>, <av.tikhomirov@...sung.com>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	Doug Anderson <dianders@...omium.org>, kishon <kishon@...com>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

Hi,

On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote:
> Hi Felipe,
> 
> 
> On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam <gautam.vivek@...sung.com> wrote:
> > Changes from v2:
> >  - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating
> >    usb 2.0 phy controller's driver for Samsung's SoCs.
> >  - Moving the register definitions and strcuture definitions to
> >    common header file 'samsung-usbphy.h' to be used across
> >    usb 2.0 and usb 3.0 phy.
> >  - Keeping common exported function definitions in samsung-usbphy.c
> >    which can be used across usb 2.0 and usb 3.0 phy.
> >  - Writting separate driver file for Samsung's USB 3.0 phy controller.
> >    and making it dependent on USB_DWC3.
> >
> 
> Is the re-organization being done here fine as per requirements for
> separate drivers for usb 2.0 type PHY and usb 3.0 type PHY ?

should be fine ;-) If there is *truly generic* pieces, it makes sense to
re-use - unless those "generic" parts are common driver churn
(platform_driver definition, module_init(), module_exit(), etc).

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)