linux-kernel - Re: memcg: cat: memory.memsw.* : Operation not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <389106003.8637801.1358757547754.JavaMail.root@redhat.com>
Date:	Mon, 21 Jan 2013 03:39:07 -0500 (EST)
From:	Zhouping Liu <zliu@...hat.com>
To:	Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	David Rientjes <rientjes@...gle.com>,
	Michal Hocko <mhocko@...e.cz>, linux-mm@...ck.org,
	Li Zefan <lizefan@...wei.com>, CAI Qian <caiqian@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>
Subject: Re: memcg: cat: memory.memsw.* : Operation not supported



----- Original Message -----
> From: "Kamezawa Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>
> To: "Tejun Heo" <tj@...nel.org>
> Cc: "David Rientjes" <rientjes@...gle.com>, "Michal Hocko" <mhocko@...e.cz>, "Zhouping Liu" <zliu@...hat.com>,
> linux-mm@...ck.org, "Li Zefan" <lizefan@...wei.com>, "CAI Qian" <caiqian@...hat.com>, "LKML"
> <linux-kernel@...r.kernel.org>, "Andrew Morton" <akpm@...ux-foundation.org>
> Sent: Saturday, June 30, 2012 11:45:41 AM
> Subject: Re: memcg: cat: memory.memsw.* : Operation not supported
> 
> (2012/06/29 3:31), Tejun Heo wrote:
> > Hello, KAME.
> >
> > On Thu, Jun 28, 2012 at 01:04:16PM +0900, Kamezawa Hiroyuki wrote:
> >>> I still wish it's folded into CONFIG_MEMCG and conditionalized
> >>> just on
> >>> CONFIG_SWAP tho.
> >>>
> >>
> >> In old days, memsw controller was not very stable. So, we devided
> >> the config.
> >> And, it makes size of memory for swap-device double (adds 2bytes
> >> per swapent.)
> >> That is the problem.
> >
> > I see.  Do you think it's now reasonable to drop the separate
> > config
> > option?  Having memcg enabled but swap unaccounted sounds
> > half-broken
> > to me.
> >
> 
> Hmm. Maybe it's ok if we can keep boot option. I'll cook a patch in
> the next week.

Hello Kame and All,

Sorry for so delay to open the thread. (please open the link https://lkml.org/lkml/2012/6/26/547 if you don't remember the topic)

do you have any updates for the issue?

I checked the latest version, if we don't open CONFIG_MEMCG_SWAP_ENABLED(commit c255a458055e changed
CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED as CONFIG_MEMCG_SWAP_ENABLED), the issue still exist:

[root@...p-8-128 ~] cat .config  | grep -i memcg
CONFIG_MEMCG=y
CONFIG_MEMCG_SWAP=y
# CONFIG_MEMCG_SWAP_ENABLED is not set
CONFIG_MEMCG_KMEM=y
[root@...p-8-128 ~] uname -r
3.8.0-rc4+
[root@...p-8-128 ~] cat memory.memsw.*
cat: memory.memsw.failcnt: Operation not supported
cat: memory.memsw.limit_in_bytes: Operation not supported
cat: memory.memsw.max_usage_in_bytes: Operation not supported
cat: memory.memsw.usage_in_bytes: Operation not supported

As David said, we should not export memory.memsw.* files if we disable CONFIG_MEMCG_SWAP_ENABLED, or return -EINVAL, right?
(please correct me if I'm wrong)

-- 
Thanks,
Zhouping
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/