linux-kernel - Re: IPsec AH use of ahash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1926711985.94035.1358729277262.JavaMail.root@elliptictech.com>
Date:	Sun, 20 Jan 2013 19:47:57 -0500 (EST)
From:	Tom St Denis <tstdenis@...iptictech.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Borislav Petkov <bp@...en8.de>, Eric Dumazet <erdnetdev@...il.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	David Miller <davem@...emloft.net>,
	steffen klassert <steffen.klassert@...unet.com>,
	herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Michal Kubecek <mkubecek@...e.cz>,
	Mike Galbraith <bitbucket@...ine.de>
Subject: Re: IPsec AH use of ahash



----- Original Message -----
> From: "Steven Rostedt" <rostedt@...dmis.org>
> To: "Tom St Denis" <tstdenis@...iptictech.com>
> Cc: "Borislav Petkov" <bp@...en8.de>, "Eric Dumazet" <erdnetdev@...il.com>, "Waskiewicz Jr, Peter P"
> <peter.p.waskiewicz.jr@...el.com>, "David Miller" <davem@...emloft.net>, "steffen klassert"
> <steffen.klassert@...unet.com>, herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
> "Michal Kubecek" <mkubecek@...e.cz>, "Mike Galbraith" <bitbucket@...ine.de>
> Sent: Sunday, 20 January, 2013 5:07:22 PM
> Subject: Re: IPsec AH use of ahash
> 
> On Sun, Jan 20, 2013 at 07:56:27AM -0500, Tom St Denis wrote:
> > 
> > You should really try running checkpatch.pl over code that's
> > already in the kernel before you call out new contributors on it.
> > 
> > How is this supposed to not be adversarial when I can't even use
> > the Kernel source itself as a reference?
> 
> So there's a lot of crap code in the kernel (that we are trying to
> clean
> up when we have the time... see Kernel Janitors). But that's still no
> excuse to allow more crap code to enter. That means adding more crap
> to
> clean up.

Nowhere in the coding guidelines I've seen thus far says that you have to comment or document your code.

I wouldn't consider fixing "crap" code to mean to change indentation style [unless the original is horrible].  It's pointless busy work at best.

If you want to improve the quality of the code I'd start with /* and end with */ once in a while.

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/