linux-kernel - Re: [patch] f2fs: use _safe() version of list_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1358760001.8234.150.camel@kjgkr>
Date:	Mon, 21 Jan 2013 18:20:01 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] f2fs: use _safe() version of list_for_each

2013-01-21 (월), 00:32 -0800, Dmitry Torokhov:
> On Sun, Jan 20, 2013 at 06:02:58PM +0300, Dan Carpenter wrote:
> > This is calling list_del() inside a loop which is a problem when we try
> > move to the next item on the list.  I've converted it to use the _safe
> > version.  And also, as a cleanup, I've converted it to use
> > list_for_each_entry instead of list_for_each.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> > Static analysis stuff.  Untested.  Please review carefully.
> 
> Makes sense to me.
> 
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 

No doubt, applied.
Thanks,

-- 
Jaegeuk Kim
Samsung

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)