linux-kernel - Re: [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Jan 2013 15:59:45 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jake Champlin <jake.champlin.27@...il.com>
Cc:	devel@...verdev.osuosl.org, sjenning@...ux.vnet.ibm.com,
	dan.magenheimer@...cle.com, konrad.wilk@...cle.com,
	linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues

On Fri, Jan 18, 2013 at 11:09:56PM -0500, Jake Champlin wrote:
> Fixed Coding Style Bracing Issues
> 
> Signed-off-by: Jake Champlin <jake.champlin.27@...il.com>
> ---
>  drivers/staging/ramster/zcache-main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ramster/zcache-main.c b/drivers/staging/ramster/zcache-main.c
> index a09dd5c..2613889 100644
> --- a/drivers/staging/ramster/zcache-main.c
> +++ b/drivers/staging/ramster/zcache-main.c
> @@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
>  #ifdef ZCACHE_DEBUG
>  	if (curr_pageframes > 2L || curr_pageframes < -2L) {
>  		/* pr_info here */
> +		/* unnecessary comment */
>  	}
>  #endif
>  }

That doesn't look like it is fixing any coding style issues, you just
added a comment for no reason?

I understand it will shut checkpatch.pl up, but be reasonable here
please, it's a tool to be used as a guideline, use your judgement
please.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/