linux-kernel - Re: [PATCH] MODSIGN: Warn when module signature checking fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d2wzwbww.fsf@rustcorp.com.au>
Date:	Mon, 21 Jan 2013 12:11:03 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Chris Samuel <chris@...muel.org>, linux-kernel@...r.kernel.org,
	dhowells@...hat.com, Josh Boyer <jwboyer@...il.com>
Subject: Re: [PATCH] MODSIGN: Warn when module signature checking fails

Stephen Rothwell <sfr@...b.auug.org.au> writes:

> Hi Rusty,
>
> On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell <rusty@...tcorp.com.au> wrote:
>>
>>  #ifdef CONFIG_MODULE_SIG
>>  	mod->sig_ok = info->sig_ok;
>> -	if (!mod->sig_ok)
>> +	if (!mod->sig_ok) {
>> +		printk_once(KERN_NOTICE
>> +			    "%s: module verification failed: signature and/or"
>> +			    " required key missing - tainting kernel\n");
>
> Did you forget to add "mod->name"?

Indeed (turns back on CONFIG_MODULE_SIG).

Thanks,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/