linux-kernel - Re: [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1358781598.6590.4.camel@hornet>
Date:	Mon, 21 Jan 2013 15:19:58 +0000
From:	Pawel Moll <pawel.moll@....com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	lm-sensors <lm-sensors@...sensors.org>,
	Jean Delvare <khali@...ux-fr.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (vexpress) Fix build error seen if
 CONFIG_OF_DEVICE is not set

On Mon, 2012-12-31 at 08:13 +0000, Guenter Roeck wrote:
> Fix:
> vexpress.c: In function ‘vexpress_hwmon_name_show’:
> vexpress.c:34:2: error: implicit declaration of function
> ‘of_get_property’ [-Werror=implicit-function-declaration]
> vexpress.c:34:27: warning: initialization makes pointer from integer
> without a cast [enabled by default]
> vexpress.c: In function ‘vexpress_hwmon_label_show’:
> vexpress.c:43:22: warning: initialization makes pointer from integer
> without a cast [enabled by default]
> 
> Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in
> of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined.
> of.h needs to be included directly.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Thanks, Guenter! (of course it's way too late for Acked-by: Pawel Moll
<pawel.moll@....com>)

Pawel



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/