linux-kernel - Re: [PATCH v9 08/11] PCI, ACPI: debug print for installation of acpi root bridge's notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXW7xkSEtxr7Wa4DQpEhdAsas7g=0bYkC+vUKp_7=Qj_A@mail.gmail.com>
Date:	Sun, 20 Jan 2013 18:37:59 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, Len Brown <lenb@...nel.org>,
	Taku Izumi <izumi.taku@...fujitsu.com>,
	Jiang Liu <jiang.liu@...wei.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	Tang Chen <tangchen@...fujitsu.com>
Subject: Re: [PATCH v9 08/11] PCI, ACPI: debug print for installation of acpi
 root bridge's notifier

On Sun, Jan 20, 2013 at 3:00 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Thursday, January 17, 2013 11:53:19 PM Yinghai Lu wrote:
>> From: Tang Chen <tangchen@...fujitsu.com>
>>
>> acpi_install_notify_handler() could fail. So check the exit status
>> and give a better debug info.
>>
>> Signed-off-by: Tang Chen <tangchen@...fujitsu.com>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> ---
>>  drivers/acpi/pci_root.c |   12 +++++++++---
>>  1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
>> index 3ce5d80..f3ceb61 100644
>> --- a/drivers/acpi/pci_root.c
>> +++ b/drivers/acpi/pci_root.c
>> @@ -762,6 +762,7 @@ static void handle_hotplug_event_root(acpi_handle handle, u32 type,
>>  static acpi_status __init
>>  find_root_bridges(acpi_handle handle, u32 lvl, void *context, void **rv)
>>  {
>> +     acpi_status status;
>>       char objname[64];
>>       struct acpi_buffer buffer = { .length = sizeof(objname),
>>                                     .pointer = objname };
>> @@ -774,9 +775,14 @@ find_root_bridges(acpi_handle handle, u32 lvl, void *context, void **rv)
>>
>>       acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
>>
>> -     acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
>> -                             handle_hotplug_event_root, NULL);
>> -     printk(KERN_DEBUG "acpi root: %s notify handler installed\n", objname);
>> +     status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
>> +                                     handle_hotplug_event_root, NULL);
>> +     if (ACPI_FAILURE(status))
>> +             printk(KERN_DEBUG "acpi root: %s notify handler is not installed, exit status: %u\n",
>
> Can you break that line, please?  And use pr_debug()?

Long line should be ok, and checkpatch.pl is not complaining about that.

Also keep the complete print out in one line, could make git grep find
that code exactly.

Actually I really hate pr_debug(), that will make the generated code
different with DEBUG
defined or not. And need to end user to recompile kernel to get debug
output if needed.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/