linux-kernel - [PATCH 2/2] samsung-laptop: Disable on EFI hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1358800838-10459-3-git-send-email-matt@console-pimps.org>
Date:	Mon, 21 Jan 2013 20:40:38 +0000
From:	Matt Fleming <matt@...sole-pimps.org>
To:	linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Cc:	Tim Gardner <rtg.canonical@...il.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"H. Peter Anvin" <hpa@...or.com>, Olof Johansson <olof@...om.net>,
	Tony Luck <tony.luck@...el.com>,
	Steve Langasek <steve.langasek@...onical.com>,
	Colin Ian King <colin.king@...onical.com>,
	Matt Fleming <matt.fleming@...el.com>,
	Corentin Chary <corentincj@...aif.net>,
	platform-driver-x86@...r.kernel.org, stable@...r.kernel.org
Subject: [PATCH 2/2] samsung-laptop: Disable on EFI hardware

From: Matt Fleming <matt.fleming@...el.com>

It has been reported that running this driver on some Samsung laptops
with EFI can cause those machines to become bricked as detailed in the
following report,

	https://bugs.launchpad.net/ubuntu-cdimage/+bug/1040557

There have also been reports of this driver causing Machine Check
Exceptions on recent EFI-enabled Samsung laptops,

	https://bugzilla.kernel.org/show_bug.cgi?id=47121

So disable it if booting from EFI since this driver relies on
grovelling around in the BIOS memory map which isn't going to work.

Acked-by: H. Peter Anvin <hpa@...or.com>
Cc: Corentin Chary <corentincj@...aif.net>
Cc: Matthew Garrett <mjg59@...f.ucam.org>
Cc: Colin Ian King <colin.king@...onical.com>
Cc: Steve Langasek <steve.langasek@...onical.com>
Cc: platform-driver-x86@...r.kernel.org
Cc: stable@...r.kernel.org
Signed-off-by: Matt Fleming <matt.fleming@...el.com>
---
 drivers/platform/x86/samsung-laptop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index dd90d15..a94c0ee 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1534,6 +1534,9 @@ static int __init samsung_init(void)
 	struct samsung_laptop *samsung;
 	int ret;
 
+	if (efi_enabled(EFI_BOOT))
+		return -ENODEV;
+
 	quirks = &samsung_unknown;
 	if (!force && !dmi_check_system(samsung_dmi_table))
 		return -ENODEV;
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/