linux-kernel - Re: [PATCH 1/2] staging/comedi: Add pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201301212225.29314.PeterHuewe@gmx.de>
Date:	Mon, 21 Jan 2013 22:25:29 +0100
From:	Peter Hüwe <PeterHuewe@....de>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Ian Abbott <abbotti@....co.uk>,
	Mori Hess <fmhess@...rs.sourceforge.net>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging/comedi: Add pci_driver.name to skel driver

Am Montag, 21. Januar 2013, 21:56:22 schrieb H Hartley Sweeten:
> On Monday, January 21, 2013 1:52 PM, Peter Huewe wrote:
> > This patch adds the comedi_driver.name to pci_driver.name
> > to the skel driver, so we can remove the workaround in drivers.c
> > 
> > Signed-off-by: Peter Huewe <peterhuewe@....de>
> > ---
> > 
> >  drivers/staging/comedi/drivers/skel.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/skel.c
> > b/drivers/staging/comedi/drivers/skel.c index e2d7970..4a40498 100644
> > --- a/drivers/staging/comedi/drivers/skel.c
> > +++ b/drivers/staging/comedi/drivers/skel.c
> > @@ -713,6 +713,7 @@ static void skel_pci_remove(struct pci_dev *dev)
> > 
> >  }
> >  
> >  static struct pci_driver skel_pci_driver = {
> > 
> > +	.name = "dummy"
> > 
> >  	.id_table = skel_pci_table,
> >  	.probe = &skel_pci_probe,
> >  	.remove = &skel_pci_remove
> 
> Hmm... I was just about to post a rebase of the last part of my drivers.c
> cleanup that included this and your 2/2 patch.
> 
> Oh well... Rebase again...
> 
> FWIW, for both patches.
> 
> Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

It's okay to drop my patches so you don't have to rebase.

(I posted a version with the missing comma nevertheless)


Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/