[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1897042.j2EJ9nIq6C@vostro.rjw.lan>
Date: Mon, 21 Jan 2013 23:42:06 +0100
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
"Kristen C. Accardi" <kristen.c.accardi@...el.com>,
Len Brown <lenb@...nel.org>
Subject: Re: [RFC][Update 2][PATCH 4/4] ACPI / PM: Expose lists of device power resources to user space
On Monday, January 21, 2013 12:58:46 PM Greg Kroah-Hartman wrote:
> On Mon, Jan 21, 2013 at 02:08:16PM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > Since ACPI power resources are going to be used more extensively on
> > new hardware platforms, it is necessary to allow user space (powertop
> > in particular) to look at the lists of power resources corresponding
> > to different power states of devices for diagnostics and control
> > purposes.
> >
> > For this reason, for each power state of an ACPI device node using
> > power resources create a special attribute group under the device
> > node's directory in sysfs containing links to sysfs directories
> > representing the power resources in that list. The names of the
> > new attribute groups are "power_resources_<state>", where <state>
> > is the state name i.e. "D0", "D1", "D2", or "D3hot".
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> You aren't calling sysfs_add_link() here, so why did you export it in
> the previous patch?
Well, unnecessarily.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists