linux-kernel - Re: [PATCH 5/5] drivers: atm: checkpatch.pl fixed coding style issues in eni.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130120.230428.1678269076372823495.davem@davemloft.net>
Date:	Sun, 20 Jan 2013 23:04:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	patrik.karlin@...il.com
Cc:	chas@....nrl.navy.mil, linux-atm-general@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] drivers: atm: checkpatch.pl fixed coding style
 issues in eni.c

From: Patrik Karlin <patrik.karlin@...il.com>
Date: Mon, 21 Jan 2013 00:12:55 +0100

> This patch fixes statement placement around if/else/for statments
> as suggested by checkpatch.pl
> 
> Signed-off-by: Patrik Kårlin <patrik.karlin@...il.com>

This patch set is a good example of why nobody should
fix up coding style in such a robotic way in response
to codingstyle.pl complaints.

> -		    ATM_MAX_AAL5_PDU) eff = (length+3) >> 2;
> +		    ATM_MAX_AAL5_PDU) 

I bet you didn't even notice that in this change you are adding
trailing whitespace, the exact problem you fixed up for this file in a
previous patch of the series.

I really would encourage you to work on something else entirely.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/