linux-kernel - Re: [PATCH] MODSIGN: Warn when module signature checking fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9s3xw9g.fsf@rustcorp.com.au>
Date:	Mon, 21 Jan 2013 10:06:11 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Chris Samuel <chris@...muel.org>, linux-kernel@...r.kernel.org,
	dhowells@...hat.com, Josh Boyer <jwboyer@...il.com>
Subject: Re: [PATCH] MODSIGN: Warn when module signature checking fails

Chris Samuel <chris@...muel.org> writes:
> /* Please CC me, I'm not on LKML */
>
> * Reworked from the original patch based on feedback from Josh Boyer
> * (putting the code in load_module()) and Rusty Russel (use
> * KERN_NOTICE).  Extended to cover the other failure modes.

We have errnos for a reason; let's not pollute the kernel logs.  That's
a userspace job.

> @@ -3115,8 +3130,10 @@ static int load_module(struct load_info *info, 
> const char __user *uargs,
>    #ifdef CONFIG_MODULE_SIG
>   	mod->sig_ok = info->sig_ok;
> -	if (!mod->sig_ok)
> +	if (!mod->sig_ok) {
> +		printk_once(KERN_NOTICE "Module verification failed: signature and/or 
> required key missing - tainting kernel\n");
>   		add_taint_module(mod, TAINT_FORCED_MODULE);
> +	}

This part is OK, but I'll add mod->name to the printk.

How's this:

module: printk message when module signature fail taints kernel.

Reported-by: Chris Samuel <chris@...muel.org>
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

diff --git a/kernel/module.c b/kernel/module.c
index ec535aa..e095e19 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3169,8 +3169,12 @@ again:
 
 #ifdef CONFIG_MODULE_SIG
 	mod->sig_ok = info->sig_ok;
-	if (!mod->sig_ok)
+	if (!mod->sig_ok) {
+		printk_once(KERN_NOTICE
+			    "%s: module verification failed: signature and/or"
+			    " required key missing - tainting kernel\n");
 		add_taint_module(mod, TAINT_FORCED_MODULE);
+	}
 #endif
 
 	/* Now module is in final location, initialize linked lists, etc. */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/