linux-kernel - Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2013 11:32:14 +0200
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
CC:	Vivek Gautam <gautamvivek1987@...il.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	<linux-usb@...r.kernel.org>, <devicetree-discuss@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<thomas.abraham@...aro.org>, <rob.herring@...xeda.com>,
	<grant.likely@...retlab.ca>, <sylvester.nawrocki@...il.com>,
	<dianders@...omium.org>, <jg1.han@...sung.com>,
	<p.paneri@...sung.com>, <cpgs@...sung.com>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

HI,

On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote:
> On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote:
> > Hi Felipe,
> > 
> > 
> > On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi <balbi@...com> wrote:
> > > HI,
> > >
> > > On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote:
> > >> Vivek Gautam wrote:
> > >> >
> > >> > Changes from v5:
> > >> >  - Rebased on top of latest patches:
> > >> >         usb: phy: samsung: Introducing usb phy driver for hsotg (v9)
> > >> >         usb: phy: samsung: Add support to set pmu isolation (v6)
> > >> >    As a result adding hostphy enable mask and hostphy register offsets
> > >> >    to driver data in order to access the HOSTPHY CONTROL register.
> > >> >
> > >> >  - Adding member 'otg' to struct samsung-usbphy so that its consumers
> > >> >    can call otg->set_host so as to make 'phy' aware of the consumer type:
> > >> >     HOST/DEVICE
> > >> >
> > >> >  - Adding 'otg' to 'struct s5p_ehci_hcd' and 'struct exynos_ohci_hcd'
> > >> >    which keeps track of 'otg' of the controllers' phy. This then sets
> > >> >    the host.
> > >> >
> > >> >  - Moved samsung_usbphy_set_type() calls from ehci-s5p and ohci-exynos
> > >> >    to phy driver itself where based on phy_type it is called.
> > >> >
> > >> >  - Added separate macro definition for USB20PHY_CFG register to select
> > >> >    between host/device type usb link.
> > >> >
> > >> >  - Removing unnecessary argument 'phy_type' from
> > >> > samsung_usbphy_set_type()
> > >> >    and samsung_usbphy_cfg_sel().
> > >> >
> > >> >  - Addressed few nits:
> > >> >     -- added macro for 'KHZ'
> > >> >     -- removing useless 'if' from samsung_usbphy_cfg_sel()
> > >> >     -- keeping the place of clk_get intact and requesting driver
> > >> >        data before that.
> > >> >
> > >> > Vivek Gautam (4):
> > >> >   ARM: EXYNOS: Update & move usb-phy types to generic include layer
> > >> >   usb: phy: samsung: Add host phy support to samsung-phy driver
> > >> >   USB: ehci-s5p: Add phy driver support
> > >> >   USB: ohci-exynos: Add phy driver support
> > >> >
> > >> >  .../devicetree/bindings/usb/samsung-usbphy.txt     |   12 +-
> > >> >  drivers/usb/host/ehci-s5p.c                        |   81 +++-
> > >> >  drivers/usb/host/ohci-exynos.c                     |   85 +++-
> > >> >  drivers/usb/phy/Kconfig                            |    2 +-
> > >> >  drivers/usb/phy/samsung-usbphy.c                   |  512
> > >> ++++++++++++++++++--
> > >> >  include/linux/usb/samsung_usb_phy.h                |   16 +
> > >> >  6 files changed, 635 insertions(+), 73 deletions(-)
> > >> >  create mode 100644 include/linux/usb/samsung_usb_phy.h
> > >> >
> > >> > --
> > >> > 1.7.6.5
> > >>
> > >> Looks good to me,
> > >>
> > >> Felipe and Greg, I don't know who should take this series anyway, feel free
> > >> to add  my ack:
> > >>
> > >> Acked-by: Kukjin Kim <kgene.kim@...sung.com>
> > >
> > > I will take care of it. But I need Alan's Acked-by for EHCI and OHCI
> > > parts.
> > >
> > 
> > We got Alan's ACK for:
> > USB: ehci-s5p: Add phy driver support
> > USB: ohci-exynos: Add phy driver support
> 
> Ok, then as soon as I get back to the office (in a few hours), I'll
> start queueing those.

Actually, if you want to make my life a little easier today, you could
resend the series with all Acks in place ;-)

ps: hehe, I'm about to go a little nuts today, too many things happening
at once ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)