linux-kernel - Re: [PATCH 08/33] gpio: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50FE7A57.4010205@free-electrons.com>
Date:	Tue, 22 Jan 2013 12:39:03 +0100
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Thierry Reding <thierry.reding@...onic-design.de>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource()

On 01/22/2013 11:15 AM, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> <thierry.reding@...onic-design.de> wrote:
> 
>> Convert all uses of devm_request_and_ioremap() to the newly introduced
>> devm_ioremap_resource() which provides more consistent error handling.
>>
>> devm_ioremap_resource() provides its own error messages so all explicit
>> error messages can be removed from the failure code paths.
>>
>> Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
>> Cc: Grant Likely <grant.likely@...retlab.ca>
>> Cc: Linus Walleij <linus.walleij@...aro.org>
> 
> Is the interface already in-kernel so I should apply this or is it
> added as part of this series so you're searching an ACK?

I don't know if I was really the one you were looking for (either
you wanted to send it to an other Greg(ory) or to Thomas Petazzoni who
wrote the gpio-mvebu.c driver). However, that's fortunate because
Thomas is currently in on vacations, so I apply this patch and the
first of the series, I built, compiled and tested it on an Aramda XP DB
board. Everything is OK for me.

So for sure you can have my
Tested-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

and as the code looks good, so for what it's worth, you can even get my
Acked-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/