linux-kernel - Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1301221443320.20374@pobox.suse.cz>
Date:	Tue, 22 Jan 2013 14:45:05 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	simon@...gewell.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support

On Tue, 22 Jan 2013, Vivien Didelot wrote:

> > > > Shouldn't the name presented in the sys/class/leds directories
> > > > change
> > > > appropriately too?
> > > 
> > > The directory name for the device under /sys/class/leds is
> > > "blink(1)::<serial>",
> > > where <serial> is the last 4 digits of the device serial number
> > > (the first 4
> > > digits are always the same: "1A00"). For instance,
> > > "blink(1)::1234".
> > > Let me know if I misunderstood your question.
> > 
> > I believe that Simon's (valid) observation is that the sysfs path
> > should
> > reflect the name change, i.e. something along the lines of
> > /sys/class/leds/thingm-blink:<serial>   ... ?
> 
> The vendor's name is "ThingM" and the product's name is "blink(1)", not "blink".
> Given that, would you prefer to keep "blink(1)::1234", or would it rather be
> "thingm-blink1::1234" (avoiding parenthesis)?
> 
> I ask the same question for the driver name, which is actually "blink(1)".

Actually, for HID bus drivers, we are mostly following the convention of 
having just the vendor name in the driver, see hid-microsoft, 
hid-logitech, etc.

So it'd make most sense to me to name the driver hid-thingm, and in case 
it is driving blink(1) device (no other devices will be driven by it 
currently), let it create /sys/class/leds/blink1... 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/