linux-kernel - Re: [PATCH 1/2] coccicheck: Allow the user to give a VERBOSE= argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50FEAAC6.3090409@itwm.fraunhofer.de>
Date:	Tue, 22 Jan 2013 16:05:42 +0100
From:	Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
To:	Nicolas Palix <nicolas.palix@...g.fr>
CC:	linux-kernel@...r.kernel.org, Julia Lawall <Julia.Lawall@...6.fr>,
	cocci@...teme.lip6.fr, Michal Marek <mmarek@...e.cz>
Subject: Re: [PATCH 1/2] coccicheck: Allow the user to give a VERBOSE= argument

Hello Nicolas,

On 01/22/2013 03:31 PM, Nicolas Palix wrote:
> Hi,
>
> Thank you Bernd for your proposition.
>
> I added Michal in CC, who is responsible for the integration.

Oh, sorry, I CCed everyone, but forgot Michal.

>
> I was wondering if the V variable which already exists would not be better
> than introducing a new variable. Bernd, is there any reason to not use V ?

I'm fine using 'V' either.

>
> Your patch also remove the check of the ONLINE variable. In doing so,
> I think that your patch will badly interfere with the online checking
> performed with the C variable. Am I missing something ?

Hmm, I probably should have told in the patch description that verbosity 
defaults to 0 now. Shall I revert or make an extra patch for that? With 
the current patch and ONLINE != 0 nothing will change.


Cheers,
Bernd


>
> Regards,
>
> On Tue, Jan 22, 2013 at 2:34 PM, Bernd Schubert
> <bernd.schubert@...m.fraunhofer.de> wrote:
>> Simply running "make coccicheck" returns very verbose output and warnings
>> might not be noticed.  Allow the user to set the verbosity level.
>>
>>
>> Signed-off-by: Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
>> CC: Julia Lawall <Julia.Lawall@...6.fr>
>> CC: Nicolas Palix <nicolas.palix@...g.fr>
>> CC: cocci@...teme.lip6.fr
>> ---
>>   scripts/coccicheck |    8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 1a49d1c..eab0b00 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -2,6 +2,12 @@
>>
>>   SPATCH="`which ${SPATCH:=spatch}`"
>>
>> +if [ -z "$VERBOSE" ] ; then
>> +       RUN_VERBOSE=0
>> +else
>> +       RUN_VERBOSE=$VERBOSE
>> +fi
>> +
>>   if [ "$C" = "1" -o "$C" = "2" ]; then
>>       ONLINE=1
>>
>> @@ -55,7 +61,7 @@ coccinelle () {
>>   #
>>   #    $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
>>
>> -    if [ "$ONLINE" = "0" ] ; then
>> +    if [ "$RUN_VERBOSE" != "0" ] ; then
>>
>>          FILE=`echo $COCCI | sed "s|$srctree/||"`
>>
>>
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/