linux-kernel - Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50FEAE96.30706@ti.com>
Date:	Tue, 22 Jan 2013 20:51:58 +0530
From:	kishon <kishon@...com>
To:	Roger Quadros <rogerq@...com>
CC:	<tony@...mide.com>, <balbi@...com>, <linux@....linux.org.uk>,
	<eballetbo@...il.com>, <javier@...hile0.org>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote:
> On 01/22/2013 04:37 PM, kishon wrote:
>> On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
>>> On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
>>>> The OMAP glue has been modified to get PHY by phandle for dt boot.
>>>>
>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>>>> ---
>>>>    drivers/usb/musb/omap2430.c |    7 ++++++-
>>>>    1 file changed, 6 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>>>> index 1a8cf6d..e43faeb 100644
>>>> --- a/drivers/usb/musb/omap2430.c
>>>> +++ b/drivers/usb/musb/omap2430.c
>>>> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
>>>>         * up through ULPI.  TWL4030-family PMICs include one,
>>>>         * which needs a driver, drivers aren't always needed.
>>>>         */
>>>> -    musb->xceiv = devm_usb_get_phy_dev(dev, 0);
>>>> +    if (dev->parent->of_node)
>>>> +        musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent,
>>>> +            "usb_phy", 0);
>>>> +    else
>>>> +        musb->xceiv = devm_usb_get_phy_dev(dev, 0);
>>>> +
>>>>        if (IS_ERR_OR_NULL(musb->xceiv)) {
>>>>            pr_err("HS USB OTG: no transceiver configured\n");
>>>>            return -ENODEV;
>>>
>>> This will not work with PHY driver as a module. You need to use deferred probing mechanism here
>>> after you have addressed my comment in patch 2 and also devm_usb_get_phy_by_phandle()
>>
>> IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver as module, since the kernel will try to probe only till the prompt comes.
>>
> Oh really? I thought deferred probing takes place whenever a new driver is bound to a device.
You might also be right. I'm not so sure.

What does "prompt comes" have to do with it?

I just meant end of boot process. But it's better to check if deferred 
probing takes place whenever a new driver is bound to a device as you 
just mentioned.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/