linux-kernel - Re: [PATCH 10/33] i2c: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130122223026.GA956@pengutronix.de>
Date:	Tue, 22 Jan 2013 23:30:26 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Arnd Bergmann <arnd@...db.de>, Ben Dooks <ben-linux@...ff.org>,
	linux-i2c@...r.kernel.org
Subject: Re: [PATCH 10/33] i2c: Convert to devm_ioremap_resource()

On Mon, Jan 21, 2013 at 11:09:03AM +0100, Thierry Reding wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
> 
> devm_ioremap_resource() provides its own error messages so all explicit
> error messages can be removed from the failure code paths.
> 
> Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
> Cc: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Ben Dooks <ben-linux@...ff.org>
> Cc: linux-i2c@...r.kernel.org

I still have the concerns I mentioned in the previous discussion but the
series seems to have enough momentum that we could also just try it.

So, for I2C:

Acked-by: Wolfram Sang <w.sang@...gutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)