linux-kernel - RE: [PATCH] staging/comedi: Use comedi_pci_auto_unconfig directly for pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2013 16:49:53 -0600
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Peter Huewe <peterhuewe@....de>, Ian Abbott <abbotti@....co.uk>
CC:	Mori Hess <fmhess@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging/comedi: Use comedi_pci_auto_unconfig directly
 for pci_driver.remove

On Tuesday, January 22, 2013 3:40 PM, Peter Huewe wrote:
>  (Almost) all comedi pci drivers have some wrapper for their
> pci_driver.remove function which simply calls comedi_pci_auto_unconfig
> which has the same function prototype as the wrapper.
>
> -> we can remove these wrappers and call comedi_pci_auto_unconfig
> directly. This removes a lot some boilerplate code and saves some bytes.
>
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
> Maybe we should move the implementation now to drivers.c,
> because now it cannot be inlined anymore. 
> This would save some more bytes in the .kos but comedi_pci_auto_unconfig
> then has to become an exported symbol.

Did you build this?

As you mention above, the inlined comedi_pci_auto_unconfig() will not
work as a function pointer in the pci_driver structs.

This cannot work until/if comedi_pci_auto_unconfig() is made an exported
symbol. I'll leave that decision up to Ian.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/