linux-kernel - Re: [PATCH 2/2] mfd: max77693: Init max77693->dev before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130122033053.GW7409@sortiz-mobl>
Date:	Tue, 22 Jan 2013 04:30:53 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Chiwoong Byun <woong.byun@...sung.com>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: max77693: Init max77693->dev before using it

Hi Axel,

On Tue, Dec 25, 2012 at 12:28:36AM +0800, Axel Lin wrote:
> Current code uses max77693->dev in the dev_err call before setting it to
> &i2c->dev. Fix it.
> 
> This patch also includes below cleanups:
>  - Move checking pdata earlier and show dev_err if no platform data found.
>  - Remove unnecessary err_regmap goto label.
>  - Unregister i2c devices if regmap init for muic fails.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/max77693.c |   34 ++++++++++++++++++----------------
>  1 file changed, 18 insertions(+), 16 deletions(-)
Applied as well, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/