linux-kernel - Re: [RFC PATCH v2 linux-next] et131x: Promote staging et131x driver to drivers/net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANK3SE2qxP5dkYrdpYnWBGqTT5b7HrW_gXS++e73Xr++h6Mokg@mail.gmail.com>
Date:	Wed, 23 Jan 2013 11:31:16 +0000
From:	Mark Einon <mark.einon@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	davem@...emloft.net, gregkh@...uxfoundation.org,
	sfr@...b.auug.org.au, devel@...verdev.osuosl.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 linux-next] et131x: Promote staging et131x driver
 to drivers/net

On 23 January 2013 10:31, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Wed, Jan 23, 2013 at 10:10:58AM +0000, Mark Einon wrote:
>> diff --git a/drivers/net/ethernet/agere/Kconfig b/drivers/net/ethernet/agere/Kconfig
>> new file mode 100644
>> index 0000000..6854966
>> --- /dev/null
>> +++ b/drivers/net/ethernet/agere/Kconfig
>> @@ -0,0 +1,32 @@
>> +#
>> +# Agere device configuration
>> +#
>> +
>> +config NET_VENDOR_AGERE
>> +       bool "Agere devices"
>> +       default y
>> +       depends on PCI
>> +       ---help---
>> +         If you have a network (Ethernet) card belonging to this class, say Y
>> +         and read the Ethernet-HOWTO, available from
>> +         <http://www.tldp.org/docs.html#howto>.
>> +
>> +         Note that the answer to this question doesn't directly affect the
>> +         kernel: saying N will just cause the configurator to skip all
>> +         the questions about Atheros devices. If you say Y, you will be asked
>                                 ^^^^^^^
> Agere?

Well spotted, thanks. I'll fix it asap.

>
>> +         for your specific card in the following questions.
>> +
>
> I think you should just leave this block out entirely.  It doesn't
> save time for anyone.

It looks to be standard boilerplate for all the net/ethernet drivers
having their own directory. I'm going to leave it in for now.
If that's an issue that needs a change, it would also affect the other
drivers and I think should be tackled as a separate thing.

Cheers,

Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/