linux-kernel - Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUW7XrOGguoPO00wxPLUr2Xc8fP=jQZwekpnmWKRewwX2g@mail.gmail.com>
Date:	Wed, 23 Jan 2013 14:33:13 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	"devendra.aaru" <devendra.aaru@...il.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

On Wed, Jan 23, 2013 at 2:17 PM, devendra.aaru <devendra.aaru@...il.com> wrote:
> On Wed, Jan 23, 2013 at 8:15 AM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>> With CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:
>>
>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>
>> Fix this by adding the missing EXPORT_SYMBOL for guest_enter() and
>> guest_exit() in kernel/context_tracking.c as suggested by Frederic.
>>
>> This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
>> add generic guest entry/exit callbacks").
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>
>> ---
>>  kernel/context_tracking.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>> index bbb2c2c..950f30a 100644
>> --- a/kernel/context_tracking.c
>> +++ b/kernel/context_tracking.c
>> @@ -111,14 +111,16 @@ void guest_enter(void)
>>         else
>>                 __guest_enter();
>>  }
>> +EXPORT_SYMBOL(guest_enter);
>>
>>  void guest_exit(void)
>> -{
>> +{i
>
> compilation fails with that?
>

Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!

- Sedat -

>
>>         if (vtime_accounting_enabled())
>>                 vtime_guest_exit(current);
>>         else
>>                 __guest_exit();
>>  }
>> +EXPORT_SYMBOL(guest_exit);
>>  #endif
>>
>>
>> --
>> 1.8.1.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/