linux-kernel - Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing include and EXPORT_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Jan 2013 17:17:56 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing include and EXPORT_SYMBOL_GPL

On Wed, Jan 23, 2013 at 5:14 PM, Frederic Weisbecker <fweisbec@...il.com> wrote:
> 2013/1/23 Sedat Dilek <sedat.dilek@...il.com>:
>> When CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:
>>
>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>
>> Fix this by removing the CONFIG_KVM ifdefs and adding missing
>> EXPORT_SYMBOL_GPL for:
>> + guest_enter() and guest_exit()
>> + vtime_guest_enter() and vtime_guest_exit()
>>
>> Also add a missing include:
>> + Add <linux/export.h> to kernel/context_tracking.c
>>
>> This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
>> add generic guest entry/exit callbacks").
>>
>> With some help of funny "i™"X86 hackerz!
>>
>> Tested on a Ubuntu/precise AMD64 with 'CONFIG_KVM=m'.
>>
>> [ vUNKNOWN: Without the magic "i" hack. -dileks ]
>> [ vUNKNOWN+1: Remove vtime.h from kvm_host.h. -dileks ]
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>
>
> Thanks you!
>
> I hope you don't mind if I fold this patch into 8eebafe9be58. If I
> apply your patch separately, my patch would break the bisection.
> But I'll add your signed-off and the appropriate co-authorship credits.

That sounds reasonable! Thanks for the vital help... Enjoyed it :-).

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/